pgsql: Be more user-friendly about unsupported cases for parallel pg_re

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Be more user-friendly about unsupported cases for parallel pg_re
Date: 2011-08-29 01:53:54
Message-ID: E1Qxr2w-00028N-6B@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Be more user-friendly about unsupported cases for parallel pg_restore.

If we are unable to do a parallel restore because the input file is stdin
or is otherwise unseekable, we should complain and fail immediately, not
after having done some of the restore. Complaining once per thread isn't
so cool either, and the messages should be worded to make it clear this is
an unsupported case not some weird race-condition bug. Per complaint from
Lonni Friedman.

Back-patch to 8.4, where parallel restore was introduced.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/d6e7abe45a64378113c1c717a831b7aac9c451df

Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 6 ++++++
src/bin/pg_dump/pg_backup_custom.c | 9 +++++++--
2 files changed, 13 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2011-08-29 02:29:45 pgsql: Actually, all of parallel restore's limitations should be tested
Previous Message Andrew Dunstan 2011-08-28 21:33:57 Re: pgsql: Allow more include files to be compiled in their own by adding m