pgsql: Obtain table locks as soon as practical during pg_dump.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Obtain table locks as soon as practical during pg_dump.
Date: 2011-06-17 22:19:56
Message-ID: E1QXhOO-0005JE-At@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Obtain table locks as soon as practical during pg_dump.

For some reason, when we (I) added table lock acquisition to pg_dump,
we didn't think about making it happen as soon as possible after the
start of the transaction. What with subsequent additions, there was
actually quite a lot going on before we got around to that; which sort
of defeats the purpose. Rearrange the order of calls in dumpSchema()
to close the risk window as much as we easily can. Back-patch to all
supported branches.

Branch
------
REL8_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/9d167bc9d8b942fd976ccea5235ad8671ef60775

Modified Files
--------------
src/bin/pg_dump/common.c | 16 +++++++++++-----
1 files changed, 11 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2011-06-17 22:24:28 pgsql: Set FLEXIBLE_ARRAY_MEMBER to empty for MSVC.
Previous Message Andrew Dunstan 2011-06-17 21:53:54 Re: pgsql: Define FLEXIBLE_ARRAY_MEMBER for MSVC.