| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Protect GIST logic that assumes penalty values can't be negative |
| Date: | 2011-05-31 21:54:38 |
| Message-ID: | E1QRWta-0000Qo-1I@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Protect GIST logic that assumes penalty values can't be negative.
Apparently sane-looking penalty code might return small negative values,
for example because of roundoff error. This will confuse places like
gistchoose(). Prevent problems by clamping negative penalty values to
zero. (Just to be really sure, I also made it force NaNs to zero.)
Back-patch to all supported branches.
Alexander Korotkov
Branch
------
REL8_4_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/8057b7554bde98d887f02f5c0c7aeca01c8b52c9
Modified Files
--------------
doc/src/sgml/gist.sgml | 2 ++
src/backend/access/gist/gistutil.c | 14 +++++++++++---
2 files changed, 13 insertions(+), 3 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2011-05-31 23:07:12 | Re: pgsql: Protect GIST logic that assumes penalty values can't be negative |
| Previous Message | Tom Lane | 2011-05-31 21:54:37 | pgsql: Protect GIST logic that assumes penalty values can't be negative |