pgsql: Fix assorted infelicities in collation handling in psql's descri

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix assorted infelicities in collation handling in psql's descri
Date: 2011-04-17 22:09:39
Message-ID: E1QBa9z-0006TA-35@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix assorted infelicities in collation handling in psql's describe.c.

In \d, be more careful to print collation only if it's not the default for
the column's data type. Avoid assuming that the name "default" is magic.

Fix \d on a composite type so that it will print per-column collations.
It's no longer the case that a composite type cannot have modifiers.
(In consequence, the expected outputs for composite-type regression tests
change.)

Fix \dD so that it will print collation for a domain, again only if it's
not the same as the base type's collation.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/c29abc8b6f5334ac2f7046a33b233776ead12395

Modified Files
--------------
src/bin/psql/describe.c | 34 +++++---
src/test/regress/expected/alter_table.out | 96 +++++++++++-----------
src/test/regress/expected/collate.linux.utf8.out | 6 +-
3 files changed, 71 insertions(+), 65 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2011-04-18 12:27:59 pgsql: recoveryStopsHere() must check the resource manager ID.
Previous Message Tom Lane 2011-04-17 21:06:13 pgsql: Document COLLATE option in CREATE TYPE reference page.