pgsql: Fix line_construct_pm() for the case of "infinite" (DBL_MAX) slo

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix line_construct_pm() for the case of "infinite" (DBL_MAX) slo
Date: 2010-11-10 22:01:05
Message-ID: E1PGIj3-0002aB-I3@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix line_construct_pm() for the case of "infinite" (DBL_MAX) slope.

This code was just plain wrong: what you got was not a line through the
given point but a line almost indistinguishable from the Y-axis, although
not truly vertical. The only caller that tries to use this function with
m == DBL_MAX is dist_ps_internal for the case where the lseg is horizontal;
it would end up producing the distance from the given point to the place
where the lseg's line crosses the Y-axis. That function is used by other
operators too, so there are several operators that could compute wrong
distances from a line segment to something else. Per bug #5745 from
jindiax.

Back-patch to all supported branches.

Branch
------
REL8_4_STABLE

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=5abb72f9af64339ed97eb991b0bd3456bd651f8e

Modified Files
--------------
src/backend/utils/adt/geo_ops.c | 15 +++++++++++----
1 files changed, 11 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message User Itagaki 2010-11-11 01:53:20 textsearch-ja - eudc: Fix a bug in conversion from SJIS to UTF8 with a
Previous Message Peter Eisentraut 2010-11-10 21:51:13 Re: Re: [COMMITTERS] pgsql: Don't unblock SIGQUIT in the SIGQUIT handler This was possibly