From: | "Albe Laurenz" <laurenz(dot)albe(at)wien(dot)gv(dot)at> |
---|---|
To: | "Tom Lane *EXTERN*" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Simon Riggs" <simon(at)2ndQuadrant(dot)com> |
Cc: | "Robert Haas" <robertmhaas(at)gmail(dot)com>, "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "Magnus Hagander" <magnus(at)hagander(dot)net>, "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: smart shutdown at end of transaction (was: Default mode for shutdown) |
Date: | 2012-04-30 07:43:12 |
Message-ID: | D960CB61B694CF459DCFB4B0128514C207CD32FF@exadv11.host.magwien.gv.at |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane wrote:
>> On Fri, Apr 27, 2012 at 7:29 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> No, I'm not happy with that. Smart shutdown is defined to not
affect
>>> current sessions. I'm fine with having a fourth mode that acts as
you
>>> suggest (and, probably, even with making it the default); but not
with
>>> taking away a behavior that people may well be relying on.
>> Agreed, but not sure what to call the new mode: "smarter"?
> I'm not necessarily opposed to commandeering the name "smart" for the
> new behavior, so that what we have to find a name for is the old
"smart"
> behavior. How about
>
> slow - allow existing sessions to finish (old "smart")
> smart - allow existing transactions to finish (new)
> fast - kill active queries
> immediate - unclean shutdown
But if the meaning of "smart" changes, then people who use
"pg_ctl stop -m smart" and expect that active sessions will not be
affected will get a surprise.
Wouldn't it be better to pick a different name for the new fourth
mode? It could still be the default mode, but I think that people
who explicitly specify a certain mode are more likely to care about
the exact behaviour.
I second Heikki's suggestions for mode names.
And +1 from me on changing the default behaviour.
Yours,
Laurenz Albe
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2012-04-30 08:18:13 | Re: 9.2 release notes, beta time? |
Previous Message | Simon Riggs | 2012-04-30 07:09:54 | Re: Future In-Core Replication |