Re: review: CHECK FUNCTION statement

From: "Albe Laurenz" <laurenz(dot)albe(at)wien(dot)gv(dot)at>
To: "Pavel Stehule *EXTERN*" <pavel(dot)stehule(at)gmail(dot)com>
Cc: "Tom Lane *EXTERN*" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "PostgreSQL Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: review: CHECK FUNCTION statement
Date: 2011-12-07 15:30:50
Message-ID: D960CB61B694CF459DCFB4B0128514C2073488E5@exadv11.host.magwien.gv.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Pavel Stehule wrote:
>> The syntax error messages are still inadequate; all I can get is
>> 'syntax error at or near "%s"'.  They should be more detailed.
>
> this system is based on error messages that generates a plpgsql engine
> or bison engine. I can correct only a few percent from these messages
> :(
>
> internally I didn't wrote a compiler or plpgsql checker - this is just
> tool that can emit some plpgsql interpret subprocess - and when these
> subprocesses raises exceptions, then takes their messages.

I see.

>> I think that at least the documentation should be improved before
>> I am ready to set this as "ready for committer".
>
> please, can you send a correction to documentation or error messages?
>
> I am not able to write documentation

I'll give it a try.

Yours,
Laurenz Albe

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2011-12-07 15:58:03 Re: Inlining comparators as a performance optimisation
Previous Message Pavel Stehule 2011-12-07 15:17:59 Re: review: CHECK FUNCTION statement