| From: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
|---|---|
| To: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
| Cc: | pgsql-bugs(at)lists(dot)postgresql(dot)org, Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Subject: | Re: BUG #15378: SP-GIST memory context screwup? |
| Date: | 2018-09-11 21:26:54 |
| Message-ID: | CAPpHfdudnGJFcbh76OjgMy2sBCGm8pMsBgZbiL4i7Vzc44kZ1g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Tue, Sep 11, 2018 at 6:47 PM Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
wrote:
> But it turns out that removing the pfree will cause transient leakage
> within the scan, since ScanStackEntry objects are also freed retail
> during a walk. ugh.
>
Right, I've missed code path freeScanStackEntry() call from spgWalk().
On Tue, Sep 11, 2018 at 9:59 PM Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
wrote:
> Andrew> Proposed patch attached.
>
> Pushed this.
>
Pushed version looks correct to me. Thank you!
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | kalyani kaniganti | 2018-09-12 01:21:44 | Re: BUG #15376: Postgres sql 9.4.19 pg_upgrade stops with error The source cluster was not shut down cleanly. |
| Previous Message | Andrew Gierth | 2018-09-11 18:59:19 | Re: BUG #15378: SP-GIST memory context screwup? |