Re: Fix KNN GiST ordering type

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Fix KNN GiST ordering type
Date: 2016-02-02 10:24:57
Message-ID: CAPpHfdt1NqHp90ctEHkK11qSKMnLTLXM7uFNCGChHh4ruF43pQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 1, 2016 at 7:31 PM, Alexander Korotkov <
a(dot)korotkov(at)postgrespro(dot)ru> wrote:

> KNN GiST detects which type it should return by returning type of ordering
> operator.
> But it appears that type of sk_func is detected after it was replaced with
> distance function. That is wrong: distance function should always return
> float8.
> I think it is just a typo.
>

I found this was introduced by this commit.
http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=821b821a2421beaa58225ff000833df69fb962c5;hp=284bef297733e553c73f1c858e0ce1532f754d18

However, commit message doesn't say anything special about this change.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2016-02-02 10:30:48 Re: get current log file
Previous Message Alvaro Herrera 2016-02-02 10:22:10 Re: Freeze avoidance of very large table.