From: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> |
---|---|
To: | Yeb Havinga <yebhavinga(at)gmail(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Parameterized aggregate subquery (was: Pull up aggregate subquery) |
Date: | 2011-07-22 15:35:40 |
Message-ID: | CAP7QgmmZDq9ZVxag1ecVKiWzDiugc-boY2DBfR=9__4A4zxYnA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
2011/7/23 Yeb Havinga <yebhavinga(at)gmail(dot)com>:
> On 2011-07-22 16:17, Hitoshi Harada wrote:
>>
>> :(
>> I updated the patch. Could you try attached once more? The "issafe"
>> switch seems wrong.
>
> Works like a charm :-). However, now there is always a copyObject of a
> subquery even when the subquery is not safe for qual pushdown. The problem
> with the previous issafe was that it was only assigned for
> rel->baserestrictinfo != NIL. If it is assigned before the if statement, it
> still works. See attached patch that avoids subquery copy for unsafe
> subqueries, and also exits best_inner_subqueryscan before palloc of
> differenttypes in case of unsafe queries.
Ah, yeah, right. Too quick fix bloated my brain :P Thanks for testing!
I'll check it more.
--
Hitoshi Harada
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2011-07-22 15:36:30 | Re: Policy on pulling in code from other projects? |
Previous Message | Robert Haas | 2011-07-22 15:34:07 | Re: Questions and experiences writing a Foreign Data Wrapper |