Re: Underspecified window queries in regression tests

From: Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Underspecified window queries in regression tests
Date: 2011-10-15 04:04:44
Message-ID: CAP7QgmkSpHPrAsrVtW82gcWpJeRGfyab9_j4zBUtREbOTCJFJw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2011/10/15 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
> I can't recall whether there was some good reason for underspecifying
> these test queries.  It looks like all the problematic ones were added in
> commit ec4be2ee6827b6bd85e0813c7a8993cfbb0e6fa7 "Extend the set of frame
> options supported for window functions", which means it was either me or
> Hitoshi-san who wrote them that way, but memory is not serving this
> afternoon.
>

I don't remember if I wrote that part or not, but I like to add
explicit ORDER BY to the test cases. It doesn't appear that some
reason stopped us to specify it. So +1 for adding the clauses.

Regards,
--
Hitoshi Harada

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2011-10-15 04:24:10 Re: Call stacks and RAISE INFO
Previous Message Jun Ishiduka 2011-10-15 02:12:36 Re: Online base backup from the hot-standby