Re: pg_hba_file_settings view patch

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_hba_file_settings view patch
Date: 2017-01-04 20:10:45
Message-ID: CANP8+jLx1e6LxCmQqDPphDcB1E8UOSwA2PpMcpvxJrJ8e+DoRw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 4 January 2017 at 03:54, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> wrote:

> Latest patch is attached.

The "method" column should be called "auth" or "auth_method" or "authentication"

I think we should have some tests, but I'll hear your views on that.
Perhaps we can include a test/sample pg_hba.conf for use in tests.

Since we've had crashes, I suggest running the test 10000 times and
checks for leaks and crashes.

If its safe we can move towards commit. Thanks

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2017-01-04 20:17:37 ALTER SYSTEM for pg_hba.conf
Previous Message Peter Eisentraut 2017-01-04 20:09:35 Re: generating fmgr prototypes automatically