Re: [PATCH] COPY vs \copy HINT

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: Christoph Berg <myon(at)debian(dot)org>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] COPY vs \copy HINT
Date: 2016-09-02 09:38:04
Message-ID: CAMsr+YHg4VX4=Hx8sUN75pS-XEE7Wz=0M73sx4G8Nhc0V_ReLw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2 September 2016 at 17:05, Christoph Berg <myon(at)debian(dot)org> wrote:
> Re: Craig Ringer 2016-09-02 <CAMsr+YFr6Sk=bbU2yCORN7z9foHF0cqx29vk5B49DswQ6EkVxg(at)mail(dot)gmail(dot)com>
>> I thought about that but figured it didn't really matter too much,
>> when thinking about examples like
>>
>> # COPY batch_demo FROM '/root/secret.csv' WITH (FORMAT CSV);
>> ERROR: could not open file "/root/secret.csv" for reading: Permission denied
>>
>> or whatever, where the user doesn't understand why they can't read the
>> file given that their local client has permission to do so.
>>
>> I don't feel strongly about this and think that the error on ENOENT is
>> by far the most important, so I'll adjust it per your recommendation.
>
> Couldn't you just add EACCESS to the check as well?

Yeah, probably. Those are really the only two failures I think it's
worth reporting for.

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Rushabh Lathia 2016-09-02 09:47:54 Re: Surprising behaviour of \set AUTOCOMMIT ON
Previous Message Amit Langote 2016-09-02 09:07:06 Re: Let file_fdw access COPY FROM PROGRAM