Re: Proposal:Use PGDLLEXPORT for libpq

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: Yury Zhuravlev <u(dot)zhuravlev(at)postgrespro(dot)ru>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Proposal:Use PGDLLEXPORT for libpq
Date: 2016-01-26 15:51:56
Message-ID: CAMsr+YFp63SYo2VinHuwMeLGjNc60fr1deTxmJT=tgrX3kHFBg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 26 January 2016 at 23:04, Yury Zhuravlev <u(dot)zhuravlev(at)postgrespro(dot)ru>
wrote:

> Hello hackers.
> Why we do not use PGDLLEXPORT (__declspec (dllexport)) for the libpq (and
> other dlls)?
> Now we are using black magic with gendef.pl for get def (aka export.txt)
> from .obj files.
> I have set for some functions and it works.
> Perhaps there is a circumstance that I do not know but my version seems to
> me simplify build under Windows.
>

See

http://www.postgresql.org/message-id/1389762012.24046.2.camel@vanquo.pezone.net

and

http://www.postgresql.org/message-id/0LiX1g-1VPi6O3RoS-00d3Jf@mrelayeu.kundenserver.de

(sorry for HTML horror)

for history.

TL;DR: PGDLLEXPORT is considered ugly Windows-droppings in the code and so
a less visible, albeit more convoluted, solution is used.

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2016-01-26 15:56:12 Re: remove wal_level archive
Previous Message Craig Ringer 2016-01-26 15:43:18 Re: pglogical - logical replication contrib module