Re: pgbench stats per script & other stuff

From: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench stats per script & other stuff
Date: 2016-03-19 18:57:20
Message-ID: CAMkU=1xs2rUv5q2F6hBE0MWE+SbhOZ+i4yASOGXQps6=G0+D3w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Mar 19, 2016 at 11:34 AM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Jeff Janes wrote:
>> On Sat, Mar 19, 2016 at 8:41 AM, Alvaro Herrera
>> <alvherre(at)2ndquadrant(dot)com> wrote:
>> > I pushed your 25, with some additional minor tweaks. I hope I didn't
>> > break anything; please test.
>>
>> I'm now getting compiler warnings:
>>
>> gcc version 4.4.7 20120313 (Red Hat 4.4.7-16) (GCC)
>>
>>
>> pgbench.c: In function 'process_builtin':
>> pgbench.c:2765: warning: 'ps.stats.lag.sum2' is used uninitialized in
>> this function
>
> Fair complaints. I suppose the following should fix them?

Yes, that fixes them.

Thanks,

Jeff

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2016-03-19 19:11:32 Re: incorrect docs for pgbench / skipped transactions
Previous Message Alvaro Herrera 2016-03-19 18:35:33 Re: incorrect docs for pgbench / skipped transactions