Re: [pgadmin-support] pgAdmin 1.18.0 + slony-I 2.2.0 + PG 9.3

From: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
To: Sven Meirsman <sven(dot)meirsman(at)gmail(dot)com>, Dave Page <dave(dot)page(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Cc: Guillaume Lelarge <guillaume(at)lelarge(dot)info>, pgAdmin Support <pgadmin-support(at)postgresql(dot)org>
Subject: Re: [pgadmin-support] pgAdmin 1.18.0 + slony-I 2.2.0 + PG 9.3
Date: 2013-10-22 07:34:07
Message-ID: CAMcbDBF26DSbfOE2kZ8200WK=tKpdoJQioE55tS7OLChwxtoJA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers pgadmin-support

Hi Dave,

We have fixed the below two issues to support in Slony version 2.2.0 with
PG 9.3 in pgAdmin.

Issue 1:-

*Bug to reproduce:-*
*
*
- Install PG 9.3 and slony 2.2.0
- Right click on database and click on option "New slony-I cluster..."
- In the dialog we are able to see the error in status bar saying "Slony-I
creation scripts not available; only joining possible"
*
*
*Solution :-*
*
*
As per the above conversation in new version of slony 2.2.0 installation
name of the sql files got changed so it is not able to find the current
slony version.

Issue 2:-

"storenode" API contains three argument in slony version 1.1 and 1.2 but in
slony version 2.0 onwards it contains only two arguments so that issue also
fixed.

As per our knowledge we have tested this patch in slony 2.2.0 with PG 9.3.

Can anyone please test this patch and let us know if any bugs.

Thanks,
Neel Patel
*
*
*
*

On Fri, Oct 11, 2013 at 5:17 PM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>wrote:

> Hi Sven,
>
> No idea regarding the next release.
>
> Thanks,
> Neel Patel
>
>
> On Fri, Oct 11, 2013 at 11:46 AM, Sven Meirsman <sven(dot)meirsman(at)gmail(dot)com>wrote:
>
>> Hi,
>>
>> Thanks for the feedback. I'm looking forward to this update. Any idea on
>> when it will be released?
>>
>> regards,
>> Sven
>>
>>
>> 2013/10/11 Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
>>
>>> Hi Sven,
>>>
>>> Sorry for the late replay, we have checked and it is a bug in pgAdmin
>>> because the name of the sql files got changed in new slony version ( v2.2.0
>>> ) which is used by the pgAdmin.
>>>
>>> *Issue :- *
>>> *
>>> *
>>> When we install the slony ( version less than 2.2.0 ) then it will
>>> install below sql files in C:\Program Files\PostgreSQL\9.3\share folder.
>>>
>>> slony1_base.sql
>>> slony1_base.v83.sql
>>> slony1_base.v84.sql
>>> slony1_funcs.sql
>>> slony1_funcs.v83.sql
>>> slony1_funcs.v84.sql
>>>
>>> Now in New version of slony 2.2.0 onwards the name of the above sql
>>> files got changed as below.
>>> *
>>> *
>>> slony1_base.2.2.0.sql
>>> slony1_base.v83.2.2.0.sql
>>> slony1_base.v84.2.2.0.sql
>>> slony1_funcs.2.2.0.sql
>>> slony1_funcs.v83.2.2.0.sql
>>> slony1_funcs.v84.2.2.0.sql
>>>
>>> As we are using above sql files names in pgAdmin to create the new slony
>>> clusters so we need to change in pgAdmin also.
>>>
>>> We are working on this issue and submit the patch once its done.
>>>
>>> Thanks,
>>> Neel Patel
>>> *
>>> *
>>>
>>>
>>> On Mon, Sep 30, 2013 at 2:05 AM, Guillaume Lelarge <
>>> guillaume(at)lelarge(dot)info> wrote:
>>>
>>>> On Sun, 2013-09-29 at 22:29 +0200, Sven Meirsman wrote:
>>>> > Sorry, My mistake.
>>>> >
>>>> > 'Binary Paths' is the section you choose at the left of the screen. It
>>>> > contains several paths, one 'PG Bin Path' is directing to my postgres
>>>> BIN
>>>> > folder like you suggest. It is the Slony-I path that contains the
>>>> path to
>>>> > the postgres SHARE folder where the slony scripts reside.
>>>> >
>>>>
>>>> Oh OK, you're right.
>>>>
>>>> On the Slony issue, I see that Dave commited a patch from Neel Patel
>>>> last thursday. This patch commit log is: "Ensure DDLScript will work
>>>> with Slony 2.2+ which has a new SQL level API.". So I guess this is what
>>>> you're looking for. This will be in the next minor release (1.18.1),
>>>> which should be available on thursday 10th october.
>>>>
>>>>
>>>> --
>>>> Guillaume
>>>> http://blog.guillaume.lelarge.info
>>>> http://www.dalibo.com
>>>>
>>>>
>>>>
>>>> --
>>>> Sent via pgadmin-support mailing list (pgadmin-support(at)postgresql(dot)org)
>>>> To make changes to your subscription:
>>>> http://www.postgresql.org/mailpref/pgadmin-support
>>>>
>>>
>>>
>>
>

Attachment Content-Type Size
Slony_2_2_0_Fix.patch application/octet-stream 4.7 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Neel Patel 2013-10-22 13:06:24 Re: [pgadmin-support] pgAdmin 1.18.0 + slony-I 2.2.0 + PG 9.3
Previous Message Dave Page 2013-10-18 12:05:23 Re: pgAgent: C++ Port - Patch Review

Browse pgadmin-support by date

  From Date Subject
Next Message Neel Patel 2013-10-22 13:06:24 Re: [pgadmin-support] pgAdmin 1.18.0 + slony-I 2.2.0 + PG 9.3
Previous Message Dinesh Kumar 2013-10-22 07:33:35 Re: PgAdmin crash on large data returned by a query