| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila(at)enterprisedb(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Subject: | Re: WAL consistency check facility |
| Date: | 2016-08-28 00:56:29 |
| Message-ID: | CAM3SWZT1GscDiKY=ZyouRKmU_NJ1tNq_Et8Vi22bQhTaBh_SzA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 25, 2016 at 9:41 AM, Kuntal Ghosh
<kuntalghosh(dot)2007(at)gmail(dot)com> wrote:
> 2. For Btree pages, I've masked BTP_HALF_DEAD, BTP_SPLIT_END,
> BTP_HAS_GARBAGE and BTP_INCOMPLETE_SPLIT flags.
Why? I think that you should only perform this kind of masking where
it's clearly strictly necessary.
It is true that nbtree can allow cases where LP_DEAD is set with only
a share lock (by read-only queries), so I can see why BTP_HAS_GARBAGE
might need to be excluded; this is comparable to the heapam's use of
hint bits. However, it is unclear why you need to mask the remaining
btpo_flags that you list, because the other flags have clear-cut roles
in various atomic operations that we WAL-log.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-08-28 03:38:04 | Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling) |
| Previous Message | Tomas Vondra | 2016-08-28 00:24:46 | src/include/catalog/pg_foreign_table.h still refers genbki.sh |