| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Greg Stark <stark(at)mit(dot)edu> |
| Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Subject: | Re: Using quicksort for every external sort run |
| Date: | 2015-12-09 03:09:04 |
| Message-ID: | CAM3SWZRvFjsANdZ6Y4K+K9G9-FHkLpTBKHEfpd4qxo1P6oNHQg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 8, 2015 at 6:44 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> On Tue, Dec 8, 2015 at 6:39 PM, Greg Stark <stark(at)mit(dot)edu> wrote:
>> Fwiw attached are two patches for perusal. One is a trivial patch to
>> add the size of the tape to trace_sort output. I guess I'll just apply
>> that without discussion.
>
> +1
>> +/*
>> + * Obtain total disk space currently used by a LogicalTapeSet, in blocks.
>> + */
>> +long
>> +LogicalTapeBlocks(LogicalTapeSet *lts, int tapenum)
>> +{
>> + return lts->tapes[tapenum].numFullBlocks * BLCKSZ + 1;
>> +}
Why multiply by BLCKSZ here?
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2015-12-09 03:12:23 | Re: Using quicksort for every external sort run |
| Previous Message | Etsuro Fujita | 2015-12-09 03:00:02 | Re: Foreign join pushdown vs EvalPlanQual |