Re: fd.c doesn't remove files on a crash-restart

On Wed, Mar 16, 2016 at 10:53 AM, Joshua D. Drake <jd(at)commandprompt(dot)com> wrote:
> fd.c[1] will remove files from pgsql_tmp on a restart but not a
> crash-restart per this comment:
>
> /*
> * NOTE: we could, but don't, call this during a post-backend-crash restart
> * cycle. The argument for not doing it is that someone might want to
> examine
> * the temp files for debugging purposes. This does however mean that
> * OpenTemporaryFile had better allow for collision with an existing temp
> * file name.
> */
>
> I understand that this is designed this way. I think it is a bad idea

FWIW, I've seen this get out of hand several times myself.

--
Peter Geoghegan