| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Greg Stark <stark(at)mit(dot)edu>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Subject: | Re: Using quicksort for every external sort run |
| Date: | 2016-03-17 21:43:21 |
| Message-ID: | CAM3SWZQvOBBfqB34rZWrMn=h_ycT-Kpph2M5HTNWNDSjM-vDQg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 17, 2016 at 1:13 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> OK, I have now committed 0001, and separately, some comment
> improvements - or at least, I think they are improvements - based on
> this discussion.
Thanks!
Your changes look good to me. It's always interesting to learn what
wasn't so obvious to you when you review my patches. It's probably
impossible to stare at something like tuplesort.c for as long as I
have and get that balance just right.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2016-03-17 21:58:53 | Re: Make primnodes.h gender neutral |
| Previous Message | David G. Johnston | 2016-03-17 21:34:48 | Re: Make primnodes.h gender neutral |