| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Subject: | Re: INSERT ... ON CONFLICT IGNORE (and UPDATE) 3.0 |
| Date: | 2015-04-22 23:40:07 |
| Message-ID: | CAM3SWZQoMpXABELTjXV8itNU_eaXOXsZUGs9uMnZuX_0WAdtSw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 22, 2015 at 3:23 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> * We need to sort out those issues with the grammar, since that only
> really applies to the inference specification. Maybe the WHERE clause
> that the inference specification accepts can be broken out. No ON
> CONFLICT UPDATE specific issues left there, AFAICT though.
I pushed some code that deals with the predicate being within parenthesis:
https://github.com/petergeoghegan/postgres/commit/358854645279523310f998dfc9cb3fe3e165ce1e
(it now follows the attributes/expressions indexes, in the style of
CREATE INDEX).
We still need to reconcile these changes to the grammar with your own,
Andres. I'm going to wait to hear back on what you think about that.
Note that this removal:
-%nonassoc DISTINCT
-%nonassoc ON
was incidental to the commit (this is the code you could have removed
when you modified the grammar, adding a new production, but didn't).
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro HORIGUCHI | 2015-04-23 00:10:02 | Re: inherit support for foreign tables |
| Previous Message | Jim Nasby | 2015-04-22 23:36:23 | Re: Freeze avoidance of very large table. |