Re: Non-Active links being referred in our source code

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Non-Active links being referred in our source code
Date: 2019-10-14 16:18:12
Message-ID: CALDaNm0LPk9vTGTBPBRv0=fX=94o4r6-DuBbHNeCN2AH5bufLw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 8, 2019 at 10:35 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, Oct 07, 2019 at 05:11:40PM +0200, Juan José Santamaría Flecha wrote:
> > About the broken links in win32_port.h, they are all referring to
> > ntstatus. As for first case that shows the code groups, there is an up
> > to date alternative. There is also an alternative for second case that
> > points to their codes and descriptions. On the other hand, the last
> > case is quoting a document that is no longer available, I would
> > suggest to rephrase the comment, thus eliminating the quote.
> >
> > Please find attached a patch with the proposed alternatives.
>
> Thanks Juan for the patch. I have checked your suggestions and it
> looks good to me, so committed. Good idea to tell about
> WIN32_NO_STATUS. I have noticed one typo on the way.
About pg_crc.h, I have made the changes with the correct links.
The patch for the same is attached.

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
0001-Updated-CRC-links-that-are-not-working.patch application/octet-stream 1.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2019-10-14 16:35:38 Re: BUG #16045: vacuum_db crash and illegal memory alloc after pg_upgrade from PG11 to PG12
Previous Message Tom Lane 2019-10-14 15:50:31 Re: stress test for parallel workers