| From: | Kashif Zeeshan <kashif(dot)zeeshan(at)enterprisedb(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Ahsan Hadi <ahsan(dot)hadi(at)gmail(dot)com>, Asif Rehman <asifr(dot)rehman(at)gmail(dot)com>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP/PoC for parallel backup |
| Date: | 2020-04-02 13:46:15 |
| Message-ID: | CAKfXphppoztBbXcOy+4z9foCgh9-93GsWethWeL75Ucg7B1Fnw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 2, 2020 at 6:23 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Apr 2, 2020 at 7:55 AM Kashif Zeeshan
> <kashif(dot)zeeshan(at)enterprisedb(dot)com> wrote:
> > Thanks alot Robert,
> > In this case the backup folder was not being emptied as the backup was
> failed, the cleanup should be done in this case too.
>
> Does it fail to clean up the backup folder in all cases where the
> backup failed, or just in this case?
>
The cleanup is done in the cases I have seen so far with base pg_basebackup
functionality (not including the parallel backup feature) with the message
"pg_basebackup: removing contents of data directory"
A similar case was also fixed for parallel backup reported by Rajkumar
where the contents of the backup folder were not cleaned up after the error.
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Regards
====================================
Kashif Zeeshan
Lead Quality Assurance Engineer / Manager
EnterpriseDB Corporation
The Enterprise Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jehan-Guillaume de Rorthais | 2020-04-02 13:49:15 | Re: [BUG] non archived WAL removed during production crash recovery |
| Previous Message | Julien Rouhaud | 2020-04-02 13:25:06 | Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view? |