Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.
Date: 2016-03-21 09:38:50
Message-ID: CAKJS1f_9CCi_t+LEgV5GWoCj3wjavcMoDc5qfcf_A0UwpQoPoA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 21 March 2016 at 10:52, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.
>
> pgbench now needs to use src/bin/psql/psqlscan.l, but it's not very clear
> how to fit that into the MSVC build system. If this doesn't work I'm going
> to need some help from somebody who actually understands those scripts ...

I see this didn't fix the problem :-(

Perl is not my native tongue, but after a little study and some
testing on a windows machine, the attached seems to fix the problem.

I've never much looked at these script before, but it seems that the
parsing of the Makefile just assumes that psqlscan.c is in the same
path as the rest of the stuff. The patch just uses some already
defined file replace functions to switch the wrong filename out for
the correct one before the Visual Studios project file is created.

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
msvc_psqlscan_fix.diff text/plain 842 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2016-03-21 09:57:47 pgsql: Second attempt at fixing MSVC build for 68ab8e8ba4a471d9.
Previous Message Tom Lane 2016-03-21 01:59:22 pgsql: Use %option bison-bridge in psql/pgbench lexers.