| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Rikard Falkeborn <rikard(dot)falkeborn(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Suspicious strcmp() in src/backend/parser/parse_expr.c |
| Date: | 2019-04-11 14:06:11 |
| Message-ID: | CAKJS1f9hkG5qKjF-LhcdfiBShKa=ZQSdfP2BZ=1Gj19g6s4Ywg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, 11 Apr 2019 at 18:51, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, Apr 11, 2019 at 12:55:49AM -0400, Tom Lane wrote:
> > I'd be +1 for that, just on the grounds of having consistent coding
> > style. But I'm not sufficiently excited about it to do the work
> > myself ...
>
> Well, here you go as per the attached as we are on it. I am not
> noticing any other spots.
Patch looks fine to me. I also made a quick pass and noticed a few
more things out of place.
formatting.c in NUM_prepare_locale()
else if (strcmp(Np->decimal, ",") !=0)
spell.c in NISortDictionary()
if (i == 0
|| strcmp(Conf->Spell[i]->p.flag, Conf->Spell[i - 1]->p.flag))
if (i == 0
|| strcmp(Conf->Spell[i]->p.flag, Conf->AffixData[curaffix]))
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-04-11 14:12:06 | Re: Suspicious strcmp() in src/backend/parser/parse_expr.c |
| Previous Message | Christoph Berg | 2019-04-11 13:58:43 | Re: BUG #15748: arrow keys doesn't work |