Re: [PATCH] Skip ALTER x SET SCHEMA if the schema didn't change

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Marti Raudsepp <marti(at)juffo(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Skip ALTER x SET SCHEMA if the schema didn't change
Date: 2015-11-05 21:40:14
Message-ID: CAKFQuwYtutvLyQ9=pBJbWe+ecmc4Ai99qMDc08ftM9oMtcu_qg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 5, 2015 at 2:15 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Thu, Nov 5, 2015 at 6:20 AM, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
> wrote:
> > I went through the patch, following are my observations,
> >
> > Patch applied with hunks and compiled with out warnings.
> > Basic tests are passed.
>
> I'm interested in hearing opinions from multiple people about the
> following two questions:
>
> 1. Is the new behavior better than the old behavior?
> 2. Will breaking backward compatibility make too many people unhappy?
>
> My guess is that the answer to the first question is "yes" and that
> the answer to the second one is "no", but this is clearly a
> significant incompatibility, so I'd like to hear some more opinions
> before concluding that we definitely want to do this.
>

​For #2 I'm not that concerned about turning an error case into a non-error.

The rationale behind #1 makes sense to me. Given all the recent work on
"IF NOT EXISTS" we obviously think that this general behavior is desirable
and we should correct this deviation from that norm.

David J.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2015-11-05 21:53:01 Re: Within CF app, "Bug Fixes" should be "Bug Fixes/Refactoring"
Previous Message Tom Lane 2015-11-05 21:35:12 Re: Brain fade in gin_extract_jsonb_path()