pgAdmin changing pg_hba.conf does not work - Mac and Windows (Fix)

From: Dhiraj Chawla <dhiraj(dot)chawla(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Dave Page <dpage(at)pgadmin(dot)org>
Subject: pgAdmin changing pg_hba.conf does not work - Mac and Windows (Fix)
Date: 2013-03-01 11:46:08
Message-ID: CAJgtxT5vxSwUBz_9ivoy1agKcbzFc7KK=QPQ9zRfd6hG1QcY=Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

Attached is the patch that fixes the issue where if a user connects to
a server, and then tries to add an entry to pg_hba.conf via
pgHbaConfig form dialog and the newly added entry does not get saved.

Actually a member variable 'isComment' in the pgHbaConfigLine class
was not initialized. This class stores data of each line of the
pg_hba.conf file. On some system the default value was set to true
while on others it was getting set to false. But for empty lines if it
is set to true, the other logic in pgHbaConfig form dialogs works as
expected and the newly added entry is getting saved properly.

Let me know your feedback on the same.

Thanks,

--
regards,

Dhiraj Chawla
Software Engineer
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Phone: +91-20-30589522

Attachment Content-Type Size
pgadmin_changing_hba_conf_issue.patch application/octet-stream 372 bytes

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2013-03-01 17:26:39 pgAdmin III commit: Fix the editing of pg_hba.conf files.
Previous Message Dave Page 2013-02-27 08:56:32 Re: Recreate views after column type change