Re: pg_basebackup is not checking IDENTIFY_SYSTEM numbre of columns

From: Jaime Casanova <jaime(at)2ndquadrant(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_basebackup is not checking IDENTIFY_SYSTEM numbre of columns
Date: 2012-01-15 21:00:26
Message-ID: CAJKUy5imndw+rd66LOvPaUkeR-GkCaznXkTFb8TgyH=Tb3PTpg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 11, 2012 at 5:11 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>
> No, no reason. Adding such a check would be a good idea.
>

ok. patch attached, it also adds a few PQclear() calls before
disconnect_and_exit().
btw, in BaseBackup() in line 1149 (after the patch is applied) there
is an exit instead of disconnect_and_exit() and that is probably a
typo too

--
Jaime Casanova         www.2ndQuadrant.com
Professional PostgreSQL: Soporte 24x7 y capacitación

Attachment Content-Type Size
basebackup_nfields.patch text/x-patch 7.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2012-01-15 21:17:54 Re: Vacuum rate limit in KBps
Previous Message Heikki Linnakangas 2012-01-15 20:23:07 Re: Our poll() based WaitLatch implementation is broken