Re: pg_basebackup is not checking IDENTIFY_SYSTEM numbre of columns

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Jaime Casanova <jaime(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_basebackup is not checking IDENTIFY_SYSTEM numbre of columns
Date: 2012-01-11 22:11:46
Message-ID: CABUevEzam_r+r+vab8QbWxWou0W7GAa_WUAFSpwH9DdRpaJJmw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 11, 2012 at 22:31, Jaime Casanova <jaime(at)2ndquadrant(dot)com> wrote:
> Hi,
>
> I just notice $SUBJECT and this could lead us to a segmentation fault
> if by accident we point to a system with a different number of columns
> in IDENTIFY_SYSTEM, at least i point pg_receivexlog from current head
> to a 9.0 instalation and got that.
>
> Any reason for not checking number of columns?

Hmm. I could've bet it did that. I must've taken that code out at some
point during refactoring.

No, no reason. Adding such a check would be a good idea.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2012-01-11 22:12:31 Re: 16-bit page checksums for 9.2
Previous Message Dimitri Fontaine 2012-01-11 21:52:03 Re: PL/Python result metadata