Re: pg_basebackup -x/X doesn't play well with archive_mode & wal_keep_segments

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_basebackup -x/X doesn't play well with archive_mode & wal_keep_segments
Date: 2015-01-05 07:22:56
Message-ID: CAHGQGwH1_Ts7uZQ1vyESJp_E257QS=ZSFMvH_RKDM2TKtqQgWA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jan 4, 2015 at 5:47 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> On 2015-01-03 16:03:36 +0100, Andres Freund wrote:
>> On 2014-12-31 16:32:19 +0100, Andres Freund wrote:
>> > On 2014-12-05 16:18:02 +0900, Fujii Masao wrote:
>> > > On Fri, Dec 5, 2014 at 9:28 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>> > > > So I think we just need to make pg_basebackup create to .ready
>> > > > files.
>> > >
>> > > s/.ready/.done? If yes, +1.
>> >
>> > That unfortunately requires changes to both backend and pg_basebackup to
>> > support fetch and stream modes respectively.
>> >
>> > I've attached a preliminary patch for this. I'd appreciate feedback. I
>> > plan to commit it in a couple of days, after some more
>> > testing/rereading.
>>
>> Attached are two updated patches that I am starting to backport
>> now. I've fixed a couple minor oversights. And tested the patches.
>
> Pushed this after some major pain with backporting.

Thanks!

> pg_basebackup really
> changed heavily since it's introduction. And desparately needs some
> restructuring.

The patch seems to break pg_receivexlog. I got the following error message
while running pg_receivexlog.

pg_receivexlog: could not create archive status file
"mmm/archive_status/000000010000000000000003.done": No such file or
directory

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2015-01-05 07:36:48 Re: Typo in function header for recently added function errhidecontext
Previous Message Fujii Masao 2015-01-05 06:28:34 Re: tracking commit timestamps