Re: Small typo in timeline.h regarding the meaning of infinity for timeline history entry

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Small typo in timeline.h regarding the meaning of infinity for timeline history entry
Date: 2015-09-15 14:38:53
Message-ID: CAHGQGwGeBR5eEW7f0F0O-MOYKbddPWrfeswEnc5HK+r7=5c4Jg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 10, 2015 at 2:37 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> Hi all,
>
> timeline.h quotes that the end point of timeline history entry means
> infinity when its value is 0. But that's not completely true, I think
> that what is meant here is InvalidXLogRecPtr:
> {
> TimeLineID tli;
> XLogRecPtr begin; /* inclusive */
> - XLogRecPtr end; /* exclusive, 0 means
> infinity */
> + XLogRecPtr end; /* exclusive,
> InvalidXLogRecPtr means
> + * infinity */
> } TimeLineHistoryEntry;
>
> And the code leads into this direction as well.

Thanks for the report and patch! Applied.

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jan Wieck 2015-09-15 14:42:42 Re: [COMMITTERS] pgsql: Fix an O(N^2) problem in foreign key references.
Previous Message Syed, Rahila 2015-09-15 14:35:55 Re: [PROPOSAL] VACUUM Progress Checker.