| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: WAL format changes |
| Date: | 2012-06-25 17:57:42 |
| Message-ID: | CAHGQGwGZo-hv2Fxm3LpCsh=mh1T_21mj7MKe35VQyBSZ6PsyVw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 26, 2012 at 2:53 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Mon, Jun 25, 2012 at 1:24 AM, Heikki Linnakangas
> <heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
>> Ok, committed all the WAL format changes now.
>
> I found the typo.
>
> In walsender.c
> - reply.write.xlogid, reply.write.xrecoff,
> - reply.flush.xlogid, reply.flush.xrecoff,
> - reply.apply.xlogid, reply.apply.xrecoff);
> + (uint32) (reply.write << 32), (uint32) reply.write,
> + (uint32) (reply.flush << 32), (uint32) reply.flush,
> + (uint32) (reply.apply << 32), (uint32) reply.apply);
>
> "<<" should be ">>". The attached patch fixes this typo.
Oh, I forgot to attach the patch.. Here is the patch.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| walsender_typo_v1.patch | application/octet-stream | 964 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2012-06-25 18:01:32 | Re: WAL format changes |
| Previous Message | Fujii Masao | 2012-06-25 17:53:39 | Re: WAL format changes |