From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> |
Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_xlogdump fails to handle WAL file with multi-page XLP_FIRST_IS_CONTRECORD data |
Date: | 2016-08-26 13:03:28 |
Message-ID: | CAHGQGwGRhjYKZJ3BWf5Z3r82K4B2A5dpHPTxPTOsw-1dTm1SzQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Mar 23, 2016 at 7:04 PM, Pavan Deolasee
<pavan(dot)deolasee(at)gmail(dot)com> wrote:
>
>
> On Wed, Mar 23, 2016 at 1:13 PM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
> wrote:
>>
>>
>> + /*
>> + * Compute targetRecOff. It should typically be greater than short
>> + * page-header since a valid record can't , but can also be zero
>> when
>> + * caller has supplied a page-aligned address or when we are
>> skipping
>> + * multi-page continuation record. It doesn't matter though
>> because
>> + * ReadPageInternal() will read at least short page-header worth
>> of
>> + * data
>> + */
>> This needs some polishing, there is an unfinished sentence here.
>>
>> + targetRecOff = tmpRecPtr % XLOG_BLCKSZ;
>> targetRecOff, pageHeaderSize and targetPagePtr could be declared
>> inside directly the new while loop.
>
>
> Thanks Michael for reviewing the patch. I've fixed these issues and new
> version is attached.
The patch looks good to me. Barring any objections,
I'll push this and back-patch to 9.3 where pg_xlogdump was added.
Regards,
--
Fujii Masao
From | Date | Subject | |
---|---|---|---|
Next Message | Jürgen Purtz | 2016-08-26 13:06:42 | Unsupported feature F867: WITH TIES |
Previous Message | Stephen Frost | 2016-08-26 12:58:11 | Re: patch proposal |