Re: brin_summarize_new_values error checking

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: brin_summarize_new_values error checking
Date: 2016-04-20 06:05:31
Message-ID: CAHGQGwEPy8SZWJBpBaSPPLbLbKuOBKv35tLNctuWaqZTZ5ARPw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 27, 2016 at 11:56 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Mon, Jan 25, 2016 at 4:03 PM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
>> In reviewing one of my patches[1], Fujii-san has pointed out that I
>> didn't include checks for being in recovery, or for working on another
>> backend's temporary index.
>>
>> I think that brin_summarize_new_values in 9.5.0 commits those same
>> sins. In its case, I don't think those are critical, as they just
>> result in getting less specific error messages that one might hope
>> for, rather than something worse like a panic.
>>
>> But still, we might want to address them.
>
> Agreed to add those checks.

Attached patch does this.

Regards,

--
Fujii Masao

Attachment Content-Type Size
add_error_checks_to_brin_summarize_new_values_v1.patch text/x-patch 1.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2016-04-20 07:16:37 Re: Support for N synchronous standby servers - take 2
Previous Message Amit Kapila 2016-04-20 05:45:25 Re: [HACKERS] Re: pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold <