Re: Patch to add functionality to specify ORDER BY in CREATE FUNCTION for SRFs

From: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
To: Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>
Cc: Atri Sharma <atri(dot)jiit(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch to add functionality to specify ORDER BY in CREATE FUNCTION for SRFs
Date: 2015-01-07 04:14:21
Message-ID: CAFjFpRdF776cuv-D8UxqSVzaUU7vikybzLjr4r=qccotsYkw2g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Not in all cases

postgres=# create function non_im_immutable_function() returns float as $$
begin
return *random()*;
end;
$$ language plpgsql *immutable*;
CREATE FUNCTION

postgres=# select proname, provolatile from pg_proc where proname =
'random' or proname = 'non_im_immutable_function';
proname | provolatile
---------------------------+-------------
random | v
non_im_immutable_function | i

postgres=# select non_im_immutable_function();
non_im_immutable_function
---------------------------
0.963812265079468
(1 row)
postgres=# select non_im_immutable_function();
non_im_immutable_function
---------------------------
0.362834882922471
(1 row)

Per definition of immutable functions, the function's output shouldn't
depend upon a volatile function e.g. random().

On Wed, Jan 7, 2015 at 5:03 AM, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com> wrote:

> On 1/6/15, 1:00 AM, Ashutosh Bapat wrote:
>
>>
>> Even checking whether the output of the function is in the right order or
>> not, has its cost. I am suggesting that we can eliminate this cost as well.
>> For example, PostgreSQL does not check whether a function is really
>> immutable or not.
>>
>
> Actually, it does:
>
> select test();
> ERROR: UPDATE is not allowed in a non-volatile function
> CONTEXT: SQL statement "UPDATE i SET i=i+1"
> PL/pgSQL function test() line 3 at SQL statement
> STATEMENT: select test();
> ERROR: UPDATE is not allowed in a non-volatile function
> CONTEXT: SQL statement "UPDATE i SET i=i+1"
> PL/pgSQL function test() line 3 at SQL statement
>
>
> --
> Jim Nasby, Data Architect, Blue Treble Consulting
> Data in Trouble? Get it in Treble! http://BlueTreble.com
>

--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2015-01-07 04:14:26 Re: [REVIEW] Re: Fix xpath() to return namespace definitions
Previous Message Michael Paquier 2015-01-07 04:02:29 Re: [REVIEW] Re: Compression of full-page-writes