| From: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
|---|---|
| To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Postgres_fdw join pushdown - wrong results with whole-row reference |
| Date: | 2016-06-29 05:38:43 |
| Message-ID: | CAFjFpRd5Pp4yen64omeUDr_4obgHN1E+Oa6cRtsMmQ=X7EYiGw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 28, 2016 at 12:52 PM, Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp
> wrote:
> On 2016/06/28 15:23, Ashutosh Bapat wrote:
>
>> The wording "column "whole-row reference ..." doesn't look good.
>> Whole-row reference is not a column. The error context itself should be
>> "whole row reference for foreign table ft1".
>>
>
> Ah, you are right. Please find attached an updated version.
>
>
This looks good to me. Regression tests pass.
--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-06-29 05:42:49 | Re: Documentation fixes for pg_visibility |
| Previous Message | Tom Lane | 2016-06-29 04:57:27 | Re: make clean didn't clean up files generated from *.(y|l) |