From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
Cc: | lulzimbilali(at)gmail(dot)com, ypercube(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
Subject: | Re: BUG #15533: error on upsert when used in a fuction and a function parameter has the same name as the column |
Date: | 2018-12-01 11:57:27 |
Message-ID: | CAFj8pRC0+fnc7jRQYbmgAi_HUXbNLXZZBSMSt_rP_Qts_5ZkqQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
so 1. 12. 2018 v 12:32 odesílatel Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
napsal:
> >>>>> "Pavel" == Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
>
> Pavel> I am strongly sure, so current default is best and any change of
> Pavel> this behave (it is simply - just use #option) is strongly wrong.
>
> I don't buy it; I call this a bug.
>
> Here's why: in an ON CONFLICT (col) clause, the (col) is not a list of
> expressions or even really a list of columns, what it is is an index
> definition (i.e. the same thing that would appear in CREATE INDEX). One
> consequence of this is that _qualified_ column names, which are a usual
> solution to variable name vs column conflicts, are not allowed here.
> There is already special processing done on the clause for this reason
> (the hiding of other tables that might be visible at this point in the
> query), and I would say that this simply doesn't go far enough and that
> parameters should be hidden too (by suppressing the columnref hooks
> while the arbiter clause is being analyzed).
>
If there a expressions are not accepted there, then I can accept your
argumentation. Second hand is a implementation.
> --
> Andrew (irc:RhodiumToad)
>
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Gierth | 2018-12-01 12:21:54 | Re: BUG #15533: error on upsert when used in a fuction and a function parameter has the same name as the column |
Previous Message | Andrew Gierth | 2018-12-01 11:31:57 | Re: BUG #15533: error on upsert when used in a fuction and a function parameter has the same name as the column |