| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Josh Kupershmidt <schmiddy(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: bugfix: --echo-hidden is not supported by \sf statements |
| Date: | 2013-02-23 04:53:41 |
| Message-ID: | CAFj8pRAkCsYtO4tyZ-gY==ftJVRDQeEEHwFK-mihnvk2LuRQhw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2013/2/23 Stephen Frost <sfrost(at)snowman(dot)net>:
> Pavel,
>
> * Pavel Stehule (pavel(dot)stehule(at)gmail(dot)com) wrote:
>> We cannot to remove minimal_error_message() because there
>> are >>two<< SQL queries and if we do fault tolerant oid lookup, then
>> still pg_get_functiondef can raise exception.
>
> Why is that? lookup_function_oid() only collects the oid to pass to
> get_create_function_cmd(), why not just issue one query to the backend?
> And use PSQLexec() to boot and get --echo-hidden, etc, for free? And
> eliminate the one-off error handling for just this case?
yes, we can do it. There is only one issue
routines for parsing function signature in regproc and regprocedure
should be updated - and I would to get some agreement than I start to
do modify core.
Regards
Pavel
>
> Thanks,
>
> Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2013-02-23 05:48:09 | New hooks for snapshot and transaction ID acquisition from external source |
| Previous Message | Stephen Frost | 2013-02-23 04:17:09 | Re: bugfix: --echo-hidden is not supported by \sf statements |