From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgbench - use enum for meta commands |
Date: | 2017-09-23 04:16:35 |
Message-ID: | CAFj8pRAeuGDftBbezDDgVWAgesbiz5OAUz8azid+tBAK_x1n5w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
2017-09-23 5:45 GMT+02:00 Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>:
>
> Minor code enhancement.
>
> While having a look at adding if/elif/else/endif to pgbench, and given the
> current gset/cset added meta commands in cf queue, it occured to me that
> repeated string comparisons to check for the various meta commands is
> neither efficient nor readable. Use an enum instead, which are extensively
> used already for other similar purposes.
>
+1
Pavel
> --
> Fabien.
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2017-09-23 04:51:16 | Re: CREATE COLLATION does not sanitize ICU's BCP 47 language tags. Should it? |
Previous Message | Tom Lane | 2017-09-23 03:56:38 | Re: CREATE COLLATION does not sanitize ICU's BCP 47 language tags. Should it? |