From: | Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com> |
---|---|
To: | Stephen Frost <sfrost(at)snowman(dot)net> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Josh Berkus <josh(at)agliodbs(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Proposal: Store "timestamptz" of database creation on "pg_database" |
Date: | 2013-01-03 15:00:05 |
Message-ID: | CAFcNs+oZTNTERzJQjWNquSsgVwxzc05e-ivzoAnybrtj_A70Hg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jan 3, 2013 at 11:41 AM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> * Fabrízio de Royes Mello (fabriziomello(at)gmail(dot)com) wrote:
> > On Thu, Jan 3, 2013 at 11:13 AM, Stephen Frost <sfrost(at)snowman(dot)net>
> wrote:
> > > Please use hard-tabs (not spaces) and the column should come before the
> > > variable length records (see the comment in pg_database.h).
> >
> > You all right... I fixed it in attached patch.
>
> You also need to fix the Anum_* values to match what's in the struct
> definition now..
>
> I'd recommend that you look over the code more closely and ensure that
> you're ordering everything correctly throughout and that it all makes
> sense..
>
>
Now I fixed it.
Regards,
--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Blog sobre TI: http://fabriziomello.blogspot.com
>> Perfil Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
Attachment | Content-Type | Size |
---|---|---|
pg_database_add_datcreated_column_v3.patch | application/octet-stream | 5.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Fabrízio de Royes Mello | 2013-01-03 15:17:07 | Re: Proposal: Store "timestamptz" of database creation on "pg_database" |
Previous Message | Peter Eisentraut | 2013-01-03 14:46:34 | Re: dynamic SQL - possible performance regression in 9.2 |