Re: new createuser option for replication role

From: Cédric Villemain <cedric(dot)villemain(dot)debian(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: new createuser option for replication role
Date: 2011-09-23 13:47:15
Message-ID: CAF6yO=2=ORKRG9K9W+=DQScevUG6udzmMXVxgaXncyu2vdm3EQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2011/9/23 Robert Haas <robertmhaas(at)gmail(dot)com>:
> On Thu, Sep 22, 2011 at 12:45 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> Agreed. Attached is the updated version of the patch. It adds two options
>> --replication and --no-replication. If neither specified, neither REPLICATION
>> nor NOREPLICATION is specified in CREATE ROLE, i.e., in this case,
>> replication privilege is granted to only superuser.
>
> Committed.  Do we need to make any changes in interactive mode, when
> we prompt?  In theory this could be either wanted or not wanted for
> either superusers or non-superusers, but I'm not really sure it's
> worth it, and I certainly don't want the command to go into
> interactive mode just because neither --replication nor
> --no-replication was specified.
>
> Thoughts?

I believe the intereactive mode is useless.

There is still an issue with the patch for the documentation: a
superuser, even with NOREPLICATION is allowed to perform
pg_start_backup() and pg_stop_backup().

>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--
Cédric Villemain +33 (0)6 20 30 22 52
http://2ndQuadrant.fr/
PostgreSQL: Support 24x7 - Développement, Expertise et Formation

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Cédric Villemain 2011-09-23 13:48:39 Re: new createuser option for replication role
Previous Message Robert Haas 2011-09-23 13:42:48 Re: DECLARE CURSOR must not contain data-modifying statements in WITH