| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Copy-editing for contrib/pg_visibility documentation. |
| Date: | 2016-10-03 01:00:29 |
| Message-ID: | CAEepm=0=VFjCcRRSBf9BFyAhME0vJBJQgoc9EvhEYLBd84xCLA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Mon, Oct 3, 2016 at 1:36 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Sat, Oct 1, 2016 at 3:33 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Copy-editing for contrib/pg_visibility documentation.
>>
>> Add omitted names for some function parameters.
>> Fix some minor grammatical issues.
>
> Why do you keep insisting on changing case where I've written "which"
> to instead say "that" in situations where AFAIK either is perfectly
> correct? I find such changes at best neutral, and in some cases
> worse.
'Which' looks OK to me too here, but I speak some kind of British
English, and it looks like at least some writers of formal American
English prefer 'that' here:
* http://www.chicagomanualofstyle.org/qanda/data/faq/topics/Whichvs.That.html?old=Whichvs.That01.html
* https://en.oxforddictionaries.com/usage/that-or-which
--
Thomas Munro
http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-10-03 02:06:18 | Re: [COMMITTERS] pgsql: Copy-editing for contrib/pg_visibility documentation. |
| Previous Message | Robert Haas | 2016-10-03 00:36:39 | Re: [COMMITTERS] pgsql: Copy-editing for contrib/pg_visibility documentation. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-10-03 01:24:13 | Re: "Re: Question about grant create on database and pg_dump/pg_dumpall |
| Previous Message | Michael Paquier | 2016-10-03 00:53:17 | Re: [PATCH] add option to pg_dumpall to exclude tables from the dump |