Re: tuplesort memory usage: grow_memtuples

From: Peter Geoghegan <peter(at)2ndquadrant(dot)com>
To: Greg Stark <stark(at)mit(dot)edu>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: tuplesort memory usage: grow_memtuples
Date: 2012-11-15 21:13:22
Message-ID: CAEYLb_Vzk_JwwHPX0qEZ9PhUFNw6E8TTfnG_YukD5++2Zb5xNw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 15 November 2012 19:54, Greg Stark <stark(at)mit(dot)edu> wrote:
> The only concern I had was about the behaviour after it did the
> special case. I didn't want it to keep doing the math and trying to
> grow again a little bit every tuple. I think I was leaning to putting
> the magic flag back.

The alternative might just be to add a new constant to the
TupSortStatus enum. That might be more logical.

--
Peter Geoghegan http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training and Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-11-15 21:23:35 Partial-index predicate proofs got dumber in 9.2
Previous Message Alvaro Herrera 2012-11-15 21:12:30 Re: [PATCH 02/14] Add support for a generic wal reading facility dubbed XLogReader