Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown)

From: Paul Guo <pguo(at)pivotal(dot)io>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Jimmy Yih <jyih(at)pivotal(dot)io>, Ashwin Agrawal <aagrawal(at)pivotal(dot)io>
Subject: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown)
Date: 2019-03-19 06:09:03
Message-ID: CAEET0ZEffUkXc48pg2iqARQgGRYDiiVxDu+yYek_bTwJF+q=Uw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello, Postgres hackers,

Please see the attached patches.

The first patch adds an option to automatically generate recovery conf
contents in related files, following pg_basebackup. In the patch,
GenerateRecoveryConf(), WriteRecoveryConf() and escape_quotes() are almost
same as them on pg_basebackup. The main difference is due to replication
slot support and code (variables) limit. It seems that we could slightly
refactor later to put some common code into another file after aligning
pg_rewind with pg_basebackup. This was tested manually and was done by
Jimmy (cc-ed), Ashiwin (cc-ed) and me.

Another patch does automatic clean shutdown by running a single mode
postgres instance if the target was not clean shut down since that is
required by pg_rewind. This was manually tested and was done by Jimmy
(cc-ed) and me. I'm not sure if we want a test case for that though.

Thanks.

Attachment Content-Type Size
0001-Ensure-target-clean-shutdown-at-beginning-of-pg_rewi.patch application/octet-stream 3.0 KB
0001-Auto-generate-recovery-conf-at-the-end-of-pg_re.patch application/octet-stream 8.4 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo Nagata 2019-03-19 06:13:04 Re: Proposal to suppress errors thrown by to_reg*()
Previous Message Darafei Komяpa Praliaskouski 2019-03-19 05:49:44 Re: [Patch] Log10 and hyperbolic functions for SQL:2016 compliance