From: | Soumyadeep Chakraborty <soumyadeep2007(at)gmail(dot)com> |
---|---|
To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
Cc: | Pavel Biryukov <79166341370(at)yandex(dot)ru>, David Rowley <dgrowleyml(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
Subject: | Re: posgres 12 bug (partitioned table) |
Date: | 2020-07-08 16:52:31 |
Message-ID: | CAE-ML+-f-01YcotKY7DNnhTUJ66G337=k9z2KUwf1RkZKg_C=Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
Hey Amit,
On Tue, Jul 7, 2020 at 7:17 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> Ah, I see. You might've noticed that ExecInsert() only ever sees leaf
> partitions, because tuple routing would've switched the result
> relation to a leaf partition by the time we are in ExecInsert(). So,
> table_tuple_insert() always refers to a leaf partition's AM. Not
> sure if you've also noticed but each leaf partition gets to own a slot
> (PartitionRoutingInfo.pi_PartitionTupleSlot), but currently it is only
> used if the leaf partition attribute numbers are not the same as the
> root partitioned table. How about we also use it if the leaf
> partition AM's table_slot_callbacks() differs from the root
> partitioned table's slot's tts_ops? That would be the case, for
> example, if the leaf partition is of Zedstore AM. In the more common
> cases where all leaf partitions are of heap AM, this would mean the
> original slot would be used as is, that is, if we accept hard-coding
> table_slot_callbacks() to return a "heap" slot for partitioned tables
> as I suggest.
Even then, we will still need to fill in the system columns explicitly as
pi_PartitionTupleSlot will not be filled with system columns after
it comes back out of table_tuple_insert() if we have a non-heap AM.
Regards,
Soumyadeep (VMware)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-07-08 21:57:00 | Re: BUG #16531: listen_addresses wide open? |
Previous Message | Tom Lane | 2020-07-08 16:24:45 | Re: BUG #16531: listen_addresses wide open? |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2020-07-08 16:53:56 | Re: Hybrid Hash/Nested Loop joins and caching results from subplans |
Previous Message | Tom Lane | 2020-07-08 16:49:49 | Re: Multi-byte character case-folding |