Re: Should TIDs be typbyval = FLOAT8PASSBYVAL to speed up CREATE INDEX CONCURRENTLY?

From: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Peter Geoghegan <pg(at)heroku(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Should TIDs be typbyval = FLOAT8PASSBYVAL to speed up CREATE INDEX CONCURRENTLY?
Date: 2015-12-11 22:26:41
Message-ID: CADkLM=epy+NYvSFFYh8YT9gjaKBnz=nnSqmg7ZEvHapqxcuH_A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Dec 11, 2015 at 12:13 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Wed, Dec 9, 2015 at 8:16 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> > On Tue, Nov 17, 2015 at 7:33 PM, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
> wrote:
> >> I'm willing, but I'm too new to the codebase to be an effective reviewer
> >> (without guidance). The one thing I can offer in the mean time is this:
> my
> >> company/client nearly always has a few spare AWS machines on the largish
> >> side where I can compile uncommitted patches and benchmark stuff for
> y'all.
> >
> > I think that this particular patch is close to being a slam-dunk, so I
> > don't think it's particularly needed here. But thanks.
>
> It never hurts to have a few extra performance test results - I'm all
> in favor of Corey doing some testing.
>
> Also, I'd be in favor of you updating the patch to reflect the
> comments from Tom and Simon on November 17th.
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Sure, the machine we called "ninefivealpha", which incidentally, failed to
find a single bug in alpha2 thru beta2, is currently idle, and concurrent
index creation times are a bugbear around these parts. Can somebody, either
in this thread or privately, outline what sort of a test they'd like to see?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2015-12-11 22:35:04 Re: Should TIDs be typbyval = FLOAT8PASSBYVAL to speed up CREATE INDEX CONCURRENTLY?
Previous Message Mark Dilger 2015-12-11 22:24:40 Re: Bootstrap DATA is a pita