| From: | Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Catalin Iacob <iacobcatalin(at)gmail(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Peter van Hardenberg <pvh(at)pvh(dot)ca>, Peter Eisentraut <peter_e(at)gmx(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch: Implement failover on libpq connect level. |
| Date: | 2016-12-05 18:59:47 |
| Message-ID: | CAD__Ougyczuuk4+V486uFwsOSCXWnfjgv5S5=GdumROqdU6Pfg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-jdbc |
On Mon, Dec 5, 2016 at 11:23 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>I think that you need a restoreErrorMessage call here:
> /* Skip any remaining addresses for this host. */
> conn->addr_cur = NULL;
> if (conn->whichhost + 1 < conn->nconnhost)
> {
> conn->status = CONNECTION_NEEDED
> restoreErrorMessage(conn, &savedMessage);
> goto keep_going;
> }
Right after seeing transaction is read-only we have restored the saved
message so I think we do not need one more restore there.
if (strncmp(val, "on", 2) == 0)
{
PQclear(res);
+ restoreErrorMessage(conn, &savedMessage);
--
Thanks and Regards
Mithun C Y
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2016-12-05 19:02:22 | Re: missing optimization - column <> column |
| Previous Message | Mithun Cy | 2016-12-05 18:23:24 | Re: Broken SSL tests in master |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-12-05 19:12:26 | Re: Patch: Implement failover on libpq connect level. |
| Previous Message | Gavin Flower | 2016-12-05 17:57:30 | Re: Patch: Implement failover on libpq connect level. |