| From: | Phil Sorber <phil(at)omniti(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] pg_isready (was: [WIP] pg_ping utility) |
| Date: | 2013-02-10 21:03:38 |
| Message-ID: | CADAkt-hUizLV8U1n1dZHuz5O6OXRZHC+Nzkrxy3PPbuDNsDynw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 8, 2013 at 1:07 PM, Phil Sorber <phil(at)omniti(dot)com> wrote:
> On Fri, Feb 8, 2013 at 12:46 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> No maybe. But I think that all the client commands should follow the
>> same rule. Otherwise a user would get confused when specifying
>> options.
>
> I would consider the rest of the apps using it as a consensus. I will
> make sure it aligns in behavior.
>
I've done as you suggested, and made sure they align with other
command line utils. What I have found is that dbname is passed
(almost) last in the param array so that it clobbers all previous
values. I have made this patch as minimal as possible basing it off of
master and not off of my previous attempt. For the record I still like
the overall design of my previous attempt better, but I have not
included a new version based on that here so as not to confuse the
issue, however I would gladly do so upon request.
Updated patch attached.
>>
>> Regards,
>>
>> --
>> Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| pg_isready_con_str_v4.diff | application/octet-stream | 4.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2013-02-10 21:47:46 | Re: backup.sgml patch that adds information on custom format backups |
| Previous Message | Noah Misch | 2013-02-10 21:02:59 | Re: BUG #7493: Postmaster messages unreadable in a Windows console |