From: | Phil Sorber <phil(at)omniti(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [WIP] pg_ping utility |
Date: | 2012-12-08 13:59:00 |
Message-ID: | CADAkt-hAEA+eDvwjfiBdK3a1jLr7rGG-tqn+CPot39JeEn7hyg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Dec 8, 2012 at 7:50 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Fri, Dec 7, 2012 at 12:56 PM, Phil Sorber <phil(at)omniti(dot)com> wrote:
>>
>> Something I was just thinking about while testing this again. I
>> mentioned the issue before about someone meaning to put -v and putting
>> -V instead and it being a potential source of problems. What about
>> making verbose the default and removing -v and adding -q to make it
>> quiet? This would also match other tools behavior. I want to get this
>> wrapped up and I am fine with it as is, but just wanted to ask what
>> others thought.
>
> Bruce mentionned that pg_isready could be used directly by pg_ctl -w.
> Default as being non-verbose would make sense. What are the other tools you
> are thinking about? Some utilities in core?
I think Bruce meant that PQPing() is used by pg_ctl -w, not that he
would use pg_isready.
I was just thinking that if someone is going to use it in a script
adding -q won't be a big deal. If someone wants to use it by hand
adding -v could become cumbersome.
>
> Except if you change the default behavior, let's change this patch status as
> ready to committer.
>
> Thanks,
>
> --
> Michael Paquier
> http://michael.otacoo.com
From | Date | Subject | |
---|---|---|---|
Next Message | Noah Misch | 2012-12-08 14:06:01 | CommitFest 2012-11 Progress |
Previous Message | Andres Freund | 2012-12-08 13:37:30 | Re: Support for REINDEX CONCURRENTLY |