Re: [PATCH 10/16] Introduce the concept that wal has a 'origin' node

From: Marko Kreen <markokr(at)gmail(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH 10/16] Introduce the concept that wal has a 'origin' node
Date: 2012-06-19 20:58:44
Message-ID: CACMqXCL7Ln5S+kXgvUCj9vL4jbA=10-h0jDkPF4iVXUejjBTvw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 18, 2012 at 6:35 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On 13 June 2012 19:28, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>> This adds a new configuration parameter multimaster_node_id which determines
>> the id used for wal originating in one cluster.
>
> Looks good and it seems this aspect at least is commitable in this CF.
>
> Design decisions I think we need to review are
>
> * Naming of field. I think origin is the right term, borrowing from Slony.

I have not read too deeply here, so maybe I am missing
some important detail here, but idea that users need
to coordinate a integer config parameter globally does not
sound too attractive to me.

Why not limit integers to local storage only and map
them to string idents on config, UI and transport?

--
marko

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2012-06-19 21:20:02 Re: Near-duplicate RI NO ACTION and RESTRICT triggers
Previous Message Robert Haas 2012-06-19 20:33:35 Re: performance regression in 9.2 when loading lots of small tables